[ 
https://issues.apache.org/jira/browse/BEAM-8630?focusedWorklogId=377067&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377067
 ]

ASF GitHub Bot logged work on BEAM-8630:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jan/20 22:03
            Start Date: 24/Jan/20 22:03
    Worklog Time Spent: 10m 
      Work Description: apilloud commented on pull request #10618: [BEAM-8630] 
Turn on BeamZetaSqlCalcRel
URL: https://github.com/apache/beam/pull/10618#discussion_r370862142
 
 

 ##########
 File path: 
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SingleRowScanConverter.java
 ##########
 @@ -18,15 +18,8 @@
 package org.apache.beam.sdk.extensions.sql.zetasql.translation;
 
 import com.google.zetasql.resolvedast.ResolvedNodes.ResolvedSingleRowScan;
-import java.math.BigDecimal;
 import java.util.List;
-import 
org.apache.beam.vendor.calcite.v1_20_0.com.google.common.collect.ImmutableList;
-import 
org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.plan.RelOptCluster;
 import org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.rel.RelNode;
-import 
org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.rel.logical.LogicalValues;
-import 
org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.rel.type.RelDataType;
-import 
org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.rex.RexLiteral;
-import 
org.apache.beam.vendor.calcite.v1_20_0.org.apache.calcite.sql.type.SqlTypeName;
 
 /** Converts a single row value. */
 class SingleRowScanConverter extends RelConverter<ResolvedSingleRowScan> {
 
 Review comment:
   Does this actually do anything anymore? Can it be deleted?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 377067)
    Time Spent: 8h 10m  (was: 8h)

> Prototype of BeamSQL Calc using ZetaSQL Expression Evaluator
> ------------------------------------------------------------
>
>                 Key: BEAM-8630
>                 URL: https://issues.apache.org/jira/browse/BEAM-8630
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql
>            Reporter: Yueyang Qiu
>            Assignee: Yueyang Qiu
>            Priority: Major
>          Time Spent: 8h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to