[
https://issues.apache.org/jira/browse/BEAM-8951?focusedWorklogId=377564&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377564
]
ASF GitHub Bot logged work on BEAM-8951:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/20 10:51
Start Date: 27/Jan/20 10:51
Worklog Time Spent: 10m
Work Description: kamilwu commented on issue #10435: [BEAM-8951] Stop
using nose in load tests
URL: https://github.com/apache/beam/pull/10435#issuecomment-578693235
Thanks @markflyhigh.
I've already pointed out the benefits in one of the comments above, let me
do this once again here.
What do we gain from moving load tests out of python test:
- Without nose, it is difficult to pass additional command-line arguments
to the test. Since load tests require additional parameters, this looks like a
blocker for us.
- As long as load tests are based on python tests, they are discovered by
nose/pytest and included in test suites running as a part of PreCommit. This is
undesirable. Load tests require additional parameters and they were never
intented to be run as a part of PreCommit. In order to prevent this behaviour,
we had developed some kind of guard[1] which skips test if certain condition is
met. If we move out of python test, this guard will not be needed anymore.
In general, this does not affect test management that much. We use gradle
task[2] to run load tests and this gradle task is the only place affected by my
changes.
Let me know if you find this answer helpful.
[1]
https://github.com/apache/beam/blob/31a5a33bd268eb93aa5eb8d1c31f5043b85b1511/sdks/python/apache_beam/testing/load_tests/pardo_test.py#L134-L139
[2]
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/testing/load_tests/build.gradle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 377564)
Time Spent: 10h 40m (was: 10.5h)
> Stop using nose in load tests
> -----------------------------
>
> Key: BEAM-8951
> URL: https://issues.apache.org/jira/browse/BEAM-8951
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kamil Wasilewski
> Assignee: Kamil Wasilewski
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> The community is considering moving away from nose to pytest:
> https://issues.apache.org/jira/browse/BEAM-3713. We should change the way of
> running Python load tests: instead of being subclasses of
> `unittest.TestCase`, they could be plain Python scripts, just like wordcount
> examples. This will bring one additional benefit: _LOAD_TEST_ENABLED_ guard
> will be no longer needed and could be safely removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
