[ https://issues.apache.org/jira/browse/BEAM-9212?focusedWorklogId=378584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378584 ]
ASF GitHub Bot logged work on BEAM-9212: ---------------------------------------- Author: ASF GitHub Bot Created on: 29/Jan/20 00:14 Start Date: 29/Jan/20 00:14 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10707: [BEAM-9212] fix zetasql struct exception URL: https://github.com/apache/beam/pull/10707#issuecomment-579534521 I thought about substituting TypeKind (which is well-defined) for Type. However, in this case the error messages could be nonsensical, for example `Expected resolved parameter foo to have type Struct, but it has type Struct`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 378584) Time Spent: 20m (was: 10m) > ZetaSQL structs always cause exception > -------------------------------------- > > Key: BEAM-9212 > URL: https://issues.apache.org/jira/browse/BEAM-9212 > Project: Beam > Issue Type: Bug > Components: dsl-sql-zetasql > Reporter: Kyle Weaver > Assignee: Kyle Weaver > Priority: Major > Fix For: Not applicable > > Time Spent: 20m > Remaining Estimate: 0h > > Because of an unimplemented method in ZetaSQL [1], StructType.toString always > throws an exception. This is bad because we always call toString implicitly > in a String.format [2]. > [1] https://github.com/google/zetasql/issues/24 > [2] > https://github.com/apache/beam/blob/b02a325409d55f1ecb7f9fb6ecc4f60a974c810d/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java#L1010-L1012 -- This message was sent by Atlassian Jira (v8.3.4#803005)