[
https://issues.apache.org/jira/browse/BEAM-8889?focusedWorklogId=379045&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379045
]
ASF GitHub Bot logged work on BEAM-8889:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/20 22:01
Start Date: 29/Jan/20 22:01
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #10617:
[BEAM-8889] adding gRPC connectivity to Beam/GCS connector
URL: https://github.com/apache/beam/pull/10617#discussion_r372655202
##########
File path:
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java
##########
@@ -427,23 +449,29 @@ public WritableByteChannel create(GcsPath path, String
type) throws IOException
*/
public WritableByteChannel create(GcsPath path, String type, Integer
uploadBufferSizeBytes)
throws IOException {
- GoogleCloudStorageWriteChannel channel =
- new GoogleCloudStorageWriteChannel(
- executorService,
- storageClient,
- new ClientRequestHelper<>(),
- path.getBucket(),
- path.getObject(),
- type,
- /* kmsKeyName= */ null,
- AsyncWriteChannelOptions.newBuilder().build(),
- new ObjectWriteConditions(),
- Collections.emptyMap());
- if (uploadBufferSizeBytes != null) {
- channel.setUploadBufferSize(uploadBufferSizeBytes);
+ if (uploadBufferSizeBytes == null) {
Review comment:
Was this addressed ? I see this being used in a number of places and
probably users can set mime type themselves since this is a pipeline option.
Can this be a breaking change for some users (or some applications of Beam) ?
For example,
https://github.com/apache/beam/blob/35da90a94953597e9e5676e1e1e70f27d2a8f064/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryRowWriter.java#L58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 379045)
Remaining Estimate: 164h 40m (was: 164h 50m)
Time Spent: 3h 20m (was: 3h 10m)
> Make GcsUtil use GoogleCloudStorage
> -----------------------------------
>
> Key: BEAM-8889
> URL: https://issues.apache.org/jira/browse/BEAM-8889
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Affects Versions: 2.16.0
> Reporter: Esun Kim
> Assignee: VASU NORI
> Priority: Major
> Labels: gcs
> Original Estimate: 168h
> Time Spent: 3h 20m
> Remaining Estimate: 164h 40m
>
> [GcsUtil|https://github.com/apache/beam/blob/master/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java]
> is a primary class to access Google Cloud Storage on Apache Beam. Current
> implementation directly creates GoogleCloudStorageReadChannel and
> GoogleCloudStorageWriteChannel by itself to read and write GCS data rather
> than using
> [GoogleCloudStorage|https://github.com/GoogleCloudPlatform/bigdata-interop/blob/master/gcsio/src/main/java/com/google/cloud/hadoop/gcsio/GoogleCloudStorage.java]
> which is an abstract class providing basic IO capability which eventually
> creates channel objects. This request is about updating GcsUtil to use
> GoogleCloudStorage to create read and write channel, which is expected
> flexible because it can easily pick up the new change; e.g. new channel
> implementation using new protocol without code change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
