[
https://issues.apache.org/jira/browse/BEAM-8590?focusedWorklogId=379706&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379706
]
ASF GitHub Bot logged work on BEAM-8590:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/20 01:34
Start Date: 31/Jan/20 01:34
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #10042: [BEAM-8590]
Support unsubscripted native types
URL: https://github.com/apache/beam/pull/10042#discussion_r373265458
##########
File path: sdks/python/apache_beam/typehints/native_type_compatibility.py
##########
@@ -223,9 +208,7 @@ def convert_to_beam_type(typ):
type_map = [
_TypeMapEntry(
- match=_match_same_type(typing.Any),
- arity=0,
- beam_type=typehints.Any),
+ match=is_Any, arity=0, beam_type=typehints.Any),
Review comment:
I think _match_same_type is no longer used. Consider removing in this or
follow up change if no longer needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 379706)
Time Spent: 1h (was: 50m)
> Python typehints: native types: consider bare container types as containing
> Any
> -------------------------------------------------------------------------------
>
> Key: BEAM-8590
> URL: https://issues.apache.org/jira/browse/BEAM-8590
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This is for convert_to_beam_type:
> For example, process(element: List) is the same as process(element:
> List[Any]).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
