[
https://issues.apache.org/jira/browse/BEAM-9167?focusedWorklogId=380227&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380227
]
ASF GitHub Bot logged work on BEAM-9167:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/20 22:24
Start Date: 31/Jan/20 22:24
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #10716: [BEAM-9167]
Metrics extraction refactoring.
URL: https://github.com/apache/beam/pull/10716#discussion_r373711557
##########
File path: sdks/go/pkg/beam/runners/direct/direct.go
##########
@@ -72,7 +72,9 @@ func Execute(ctx context.Context, p *beam.Pipeline) error {
if err = plan.Down(ctx); err != nil {
return err
}
- metrics.DumpToLog(ctx)
+ // TODO(lostluck) 2020/01/24: What's the right way to expose the
+ // metrics store for the direct runner?
+ metrics.DumpToLogFromStore(ctx, plan.Store)
Review comment:
It's more of a general comment of how do we give users programmatic access
to the metrics after pipeline completion. So there's nothing wrong with the way
the direct runner dumps the metrics every time. That's fine.
We likely need an extractor registration set up, to go along with the runner
Execute registration, as in the absence of a reliable job management server,
there's no common way for runners to return metrics to the users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 380227)
Time Spent: 3h (was: 2h 50m)
> Reduce overhead of Go SDK side metrics
> --------------------------------------
>
> Key: BEAM-9167
> URL: https://issues.apache.org/jira/browse/BEAM-9167
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Locking overhead due to the global store and local caches of SDK counter data
> can dominate certain workloads, which means we can do better.
> Instead of having a global store of metrics data to extract counters, we
> should use per ptransform (or per bundle) counter sets, which would avoid
> requiring locking per counter operation. The main detriment compared to the
> current implementation is that a user would need to add their own locking if
> they were to spawn multiple goroutines to process a Bundle's work in a DoFn.
> Given that self multithreaded DoFns aren't recommended/safe in Java, largely
> impossible in Python, and the other beam Go SDK provided constructs (like
> Iterators and Emitters) are not thread safe, this is a small concern,
> provided the documentation is clear on this.
> Removing the locking and switching to atomic ops reduces the overhead
> significantly in example jobs and in the benchmarks.
> A second part of this change should be to move the exec package to manage
> it's own per bundle state, rather than relying on a global datastore to
> extract the per bundle,per ptransform values.
> Related: https://issues.apache.org/jira/browse/BEAM-6541
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
