[
https://issues.apache.org/jira/browse/BEAM-7310?focusedWorklogId=380953&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380953
]
ASF GitHub Bot logged work on BEAM-7310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/20 13:53
Start Date: 03/Feb/20 13:53
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #10563: [BEAM-7310]
Add support of Confluent Schema Registry for KafkaIO
URL: https://github.com/apache/beam/pull/10563#discussion_r374090929
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -586,6 +628,40 @@ public void setValueDeserializer(String
valueDeserializer) {
return
toBuilder().setValueDeserializer(valueDeserializer).setValueCoder(valueCoder).build();
}
+ /**
+ * Allows to specify custom {@link CSRClientProvider}. {@link
CSRClientProvider} provides {@link
+ * SchemaRegistryClient} instance which is used later for communication
with Confluent Schema
+ * Registry. You should use this method if {@link
Read#withCSRClientProvider(String, String,
+ * String)} does not suit your needs.
+ */
+ public Read<K, V> withCSRClientProvider(CSRClientProvider
csrClientProvider) {
Review comment:
I would make this one package private until someone really asks for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 380953)
Time Spent: 10h 40m (was: 10.5h)
> Confluent Schema Registry support in KafkaIO
> --------------------------------------------
>
> Key: BEAM-7310
> URL: https://issues.apache.org/jira/browse/BEAM-7310
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kafka
> Affects Versions: 2.12.0
> Reporter: Yohei Shimomae
> Assignee: Alexey Romanenko
> Priority: Minor
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> Confluent Schema Registry is useful when we manage Avro Schema but KafkaIO
> does not support Confluent Schema Registry as discussed here.
> https://stackoverflow.com/questions/56035121/unable-to-connect-from-dataflow-job-to-schema-registry-when-schema-registry-requ
> https://lists.apache.org/thread.html/7695fccddebd08733b80ae1e43b79b636b63cd5fe583a2bdeecda6c4@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
