[
https://issues.apache.org/jira/browse/BEAM-3221?focusedWorklogId=381162&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381162
]
ASF GitHub Bot logged work on BEAM-3221:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/20 19:34
Start Date: 03/Feb/20 19:34
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10754: [BEAM-3221]
Expand/clarify timestamp comments within beam_runner_api.proto
URL: https://github.com/apache/beam/pull/10754#discussion_r374297835
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -37,15 +37,21 @@ import "google/protobuf/timestamp.proto";
message BeamConstants {
enum Constants {
// All timestamps in milliseconds since Jan 1, 1970.
+
+ // All timestamps of elements or window boundaries must be within
+ // the interval [MIN_TIMESTAMP_MILLIS, MAX_TIMESTAMP_MILLIS].
+ // The smallest representable timestamp of an element or a window boundary.
MIN_TIMESTAMP_MILLIS = 0 [(beam_constant) = "-9223372036854775"];
+ // The largest representable timestamp of an element or a window boundary.
MAX_TIMESTAMP_MILLIS = 1 [(beam_constant) = "9223372036854775"];
+
// The maximum timestamp for the global window.
- // Triggers use maxTimestamp to set timers' timestamp. Timers fires when
+ // Triggers use max timestamp to set timers' timestamp. Timers fire when
// the watermark passes their timestamps. So, the timestamp needs to be
// smaller than the MAX_TIMESTAMP_MILLIS.
// One standard day is subtracted from MAX_TIMESTAMP_MILLIS to make sure
- // the maxTimestamp is smaller than MAX_TIMESTAMP_MILLIS even after
rounding up
- // to seconds or minutes. See also GlobalWindow in the Java SDK.
+ // the max timestamp is smaller than MAX_TIMESTAMP_MILLIS even after
rounding up
+ // to seconds or minutes.
GLOBAL_WINDOW_MAX_TIMESTAMP_MILLIS = 2 [(beam_constant) =
"9223371950454775"];
Review comment:
We would need to define an EnumValueOption for each type we would like to
support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 381162)
Time Spent: 40m (was: 0.5h)
> Model pipeline representation improvements
> ------------------------------------------
>
> Key: BEAM-3221
> URL: https://issues.apache.org/jira/browse/BEAM-3221
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Priority: Major
> Labels: portability
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Collections of various (breaking) tweaks to the Runner API, notably the
> pipeline representation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
