[ 
https://issues.apache.org/jira/browse/BEAM-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029981#comment-17029981
 ] 

Tomo Suzuki commented on BEAM-8758:
-----------------------------------

GcpApiSurfaceTest fails with google-cloud-spanner 1.49.1:

{noformat}
java.lang.AssertionError: 
Expected: API surface to include only:
        Classes in package "com.google.api.core"
        Classes in package "com.google.api.client.googleapis"
        Classes in package "com.google.api.client.http"
        Classes in package "com.google.api.client.json"
        Classes in package "com.google.api.client.util"
        Classes in package "com.google.api.services.bigquery.model"
        Classes in package "com.google.auth"
        Classes in package "com.google.bigtable.v2"
        Classes in package "com.google.cloud.bigquery.storage.v1beta1"
        Classes in package "com.google.cloud.bigtable.config"
        Classes in package "com.google.spanner.v1"
        Classes in package "com.google.pubsub.v1"
        <class com.google.api.gax.rpc.ApiException>
        <interface com.google.api.gax.longrunning.OperationFuture>
        <interface com.google.api.gax.longrunning.OperationSnapshot>
        <interface com.google.api.gax.paging.Page>
        <interface com.google.api.gax.retrying.RetryingFuture>
        <class com.google.api.gax.retrying.RetrySettings>
        <class com.google.api.gax.retrying.RetrySettings$Builder>
        <class com.google.api.gax.retrying.TimedAttemptSettings>
        <class com.google.api.gax.retrying.TimedAttemptSettings$Builder>
        <interface com.google.api.gax.rpc.StatusCode>
        <class com.google.api.gax.rpc.StatusCode$Code>
        <class com.google.cloud.bigtable.grpc.BigtableClusterName>
        <class com.google.cloud.bigtable.grpc.BigtableInstanceName>
        <class com.google.cloud.bigtable.grpc.BigtableTableName>
        <class com.google.cloud.BaseServiceException>
        <class com.google.cloud.BaseServiceException$Error>
        <class com.google.cloud.BaseServiceException$ExceptionData>
        <class com.google.cloud.BaseServiceException$ExceptionData$Builder>
        <class com.google.cloud.RetryHelper$RetryHelperException>
        <class com.google.cloud.grpc.BaseGrpcServiceException>
        <class com.google.cloud.ByteArray>
        <class com.google.cloud.Date>
        <class com.google.cloud.Timestamp>
        Classes in package "com.google.cloud.spanner"
        Classes in package "com.google.spanner.admin.database.v1"
        Classes in package "com.google.datastore.v1"
        Classes in package "com.google.protobuf"
        Classes in package "com.google.type"
        Classes in package "com.fasterxml.jackson.annotation"
        Classes in package "com.fasterxml.jackson.core"
        Classes in package "com.fasterxml.jackson.databind"
        Classes in package "io.grpc"
        Classes in package "java"
        Classes in package "javax"
        Classes in package "org.apache.avro"
        Classes in package "org.apache.beam"
        Classes in package "org.apache.commons.logging"
        Classes in package "org.codehaus.jackson"
        Classes in package "org.joda.time"
        Classes in package "org.threeten.bp"
        
     but: The following disallowed classes appeared on the API surface:
        class com.google.cloud.Identity exposed via:
                class com.google.cloud.Identity
                class com.google.cloud.Policy$Marshaller
                class com.google.cloud.Policy$DefaultMarshaller
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        class com.google.cloud.Identity$Type exposed via:
                class com.google.cloud.Identity$Type
                class com.google.cloud.Identity
                class com.google.cloud.Policy$Marshaller
                class com.google.cloud.Policy$DefaultMarshaller
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        class com.google.cloud.Policy exposed via:
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        class com.google.cloud.Policy$Builder exposed via:
                class com.google.cloud.Policy$Builder
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        class com.google.cloud.Policy$DefaultMarshaller exposed via:
                class com.google.cloud.Policy$DefaultMarshaller
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        class com.google.cloud.Policy$Marshaller exposed via:
                class com.google.cloud.Policy$Marshaller
                class com.google.cloud.Policy$DefaultMarshaller
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        class com.google.cloud.Role exposed via:
                class com.google.cloud.Role
                class com.google.cloud.Policy$Builder
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        class com.google.cloud.StringEnumValue exposed via:
                class com.google.cloud.StringEnumValue
                class com.google.cloud.Identity$Type
                class com.google.cloud.Identity
                class com.google.cloud.Policy$Marshaller
                class com.google.cloud.Policy$DefaultMarshaller
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        class com.google.iam.v1.Binding exposed via:
                class com.google.iam.v1.Binding
                interface com.google.iam.v1.PolicyOrBuilder
                class com.google.iam.v1.Policy
                class com.google.cloud.Policy$DefaultMarshaller
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        class com.google.iam.v1.Binding$Builder exposed via:
                class com.google.iam.v1.Binding$Builder
                class com.google.iam.v1.Policy$Builder
                class com.google.iam.v1.Policy
                class com.google.cloud.Policy$DefaultMarshaller
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        class com.google.iam.v1.Policy exposed via:
                class com.google.iam.v1.Policy
                class com.google.cloud.Policy$DefaultMarshaller
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        class com.google.iam.v1.Policy$Builder exposed via:
                class com.google.iam.v1.Policy$Builder
                class com.google.iam.v1.Policy
                class com.google.cloud.Policy$DefaultMarshaller
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        interface com.google.iam.v1.BindingOrBuilder exposed via:
                interface com.google.iam.v1.BindingOrBuilder
                interface com.google.iam.v1.PolicyOrBuilder
                class com.google.iam.v1.Policy
                class com.google.cloud.Policy$DefaultMarshaller
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
        interface com.google.iam.v1.PolicyOrBuilder exposed via:
                interface com.google.iam.v1.PolicyOrBuilder
                class com.google.iam.v1.Policy
                class com.google.cloud.Policy$DefaultMarshaller
                class com.google.cloud.Policy
                interface com.google.cloud.spanner.DatabaseAdminClient
                class org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor
{noformat}

Trying to update tests to discuss this change is acceptable.

> Beam Dependency Update Request: com.google.cloud:google-cloud-spanner
> ---------------------------------------------------------------------
>
>                 Key: BEAM-8758
>                 URL: https://issues.apache.org/jira/browse/BEAM-8758
>             Project: Beam
>          Issue Type: Sub-task
>          Components: dependencies
>            Reporter: Beam JIRA Bot
>            Priority: Major
>
>  ------------------------- 2019-11-19 21:05:29.289016 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-spanner. 
>         The current version is 1.6.0. The latest version is 1.46.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2019-12-02 12:11:08.926875 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-spanner. 
>         The current version is 1.6.0. The latest version is 1.46.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2019-12-09 12:10:16.400168 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-spanner. 
>         The current version is 1.6.0. The latest version is 1.47.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2019-12-23 12:10:17.656471 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-spanner. 
>         The current version is 1.6.0. The latest version is 1.47.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2019-12-30 14:05:49.080960 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-spanner. 
>         The current version is 1.6.0. The latest version is 1.47.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2020-01-06 12:09:23.346857 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-spanner. 
>         The current version is 1.6.0. The latest version is 1.47.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2020-01-13 12:09:02.023131 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-spanner. 
>         The current version is 1.6.0. The latest version is 1.47.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2020-01-20 12:08:38.419575 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-spanner. 
>         The current version is 1.6.0. The latest version is 1.48.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2020-01-27 12:09:44.298346 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-spanner. 
>         The current version is 1.6.0. The latest version is 1.49.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2020-02-03 12:10:52.455618 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.cloud:google-cloud-spanner. 
>         The current version is 1.6.0. The latest version is 1.49.1 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to