[
https://issues.apache.org/jira/browse/BEAM-4461?focusedWorklogId=381942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381942
]
ASF GitHub Bot logged work on BEAM-4461:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/20 23:06
Start Date: 04/Feb/20 23:06
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10766:
[BEAM-4461] Add Selected.flattenedSchema
URL: https://github.com/apache/beam/pull/10766#discussion_r374974662
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/FieldAccessDescriptor.java
##########
@@ -300,6 +340,16 @@ public FieldAccessDescriptor withNestedField(
return withNestedField(field, fieldAccess);
}
+ public FieldAccessDescriptor withNestedFieldAs(
+ String nestedFieldName, String nestedFieldRename, FieldAccessDescriptor
fieldAccess) {
+ FieldDescriptor field =
+ FieldDescriptor.builder()
+ .setFieldName(nestedFieldName)
+ .setFieldRename(nestedFieldRename)
+ .build();
+ return withNestedField(field, fieldAccess);
+ }
+
Review comment:
Consider adding a test for this in `FieldAccessDescriptorTest`, and adding a
docstring
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 381942)
Time Spent: 29h 10m (was: 29h)
> Create a library of useful transforms that use schemas
> ------------------------------------------------------
>
> Key: BEAM-4461
> URL: https://issues.apache.org/jira/browse/BEAM-4461
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 29h 10m
> Remaining Estimate: 0h
>
> e.g. JoinBy(fields). Project, Filter, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
