[
https://issues.apache.org/jira/browse/BEAM-3453?focusedWorklogId=381969&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381969
]
ASF GitHub Bot logged work on BEAM-3453:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/20 00:40
Start Date: 05/Feb/20 00:40
Worklog Time Spent: 10m
Work Description: davidyan74 commented on pull request #10762:
[BEAM-3453] Use default project when creating pubsub subscription
URL: https://github.com/apache/beam/pull/10762#discussion_r375003261
##########
File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
##########
@@ -516,7 +524,7 @@ def get_subscription(cls, transform, project,
short_topic_name,
sub_client = pubsub.SubscriberClient()
sub_name = sub_client.subscription_path(
- project, 'beam_%d_%x' % (int(time.time()), random.randrange(1 << 32)))
+ sub_project, 'beam_%d_%x' % (int(time.time()), random.randrange(1 <<
32)))
Review comment:
Falling back to topic's project may make things less predictable, and
failure to create the subscription could be transient and could be because of
many reasons. The user should be sure which project it will create the
subscription under. My take is that using the topic's project was a mistake
from the beginning and it should be fixed. But let me know if you have other
thoughts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 381969)
Time Spent: 50m (was: 40m)
> Allow usage of public Google PubSub topics in Python DirectRunner
> -----------------------------------------------------------------
>
> Key: BEAM-3453
> URL: https://issues.apache.org/jira/browse/BEAM-3453
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Affects Versions: 2.2.0
> Reporter: Charles Chen
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, the Beam Python DirectRunner does not allow the usage of data from
> public Google Cloud PubSub topics. We should allow this functionality so
> that users can more easily test Beam Python's streaming functionality.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
