[
https://issues.apache.org/jira/browse/BEAM-2645?focusedWorklogId=382602&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382602
]
ASF GitHub Bot logged work on BEAM-2645:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/20 23:43
Start Date: 05/Feb/20 23:43
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10770: [BEAM-2645]
Define the display data model type
URL: https://github.com/apache/beam/pull/10770#discussion_r375569755
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1205,58 +1207,58 @@ message FunctionSpec {
bytes payload = 3;
}
-// TODO: transfer javadoc here
-message DisplayData {
-
- // (Required) The list of display data.
- repeated Item items = 1;
-
- // A complete identifier for a DisplayData.Item
- message Identifier {
-
- // (Required) The transform originating this display data.
- string transform_id = 1;
-
- // (Optional) The URN indicating the type of the originating transform,
- // if there is one.
- string transform_urn = 2;
-
- string key = 3;
+// A set of well known URNs describing display data.
+//
+// All descriptions must contain how the value should be classified and how it
+// is encoded. Note that some types are logical types which convey contextual
+// information about the pipeline in addition to an encoding while others only
+// specify the encoding itself.
+message StandardDisplayData {
+ enum DisplayData {
+ // A string label and value. Has a payload containing an encoded
+ // LabelledStringPayload.
+ LABELLED_STRING = 0 [(beam_urn) = "beam:display_data:labelled_string:v1"];
Review comment:
Isn't it best practice to start with 1, so that unset == 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 382602)
Time Spent: 40m (was: 0.5h)
> Implement DisplayData translation to/from protos
> ------------------------------------------------
>
> Key: BEAM-2645
> URL: https://issues.apache.org/jira/browse/BEAM-2645
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
