[
https://issues.apache.org/jira/browse/BEAM-9229?focusedWorklogId=382611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382611
]
ASF GitHub Bot logged work on BEAM-9229:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/20 00:10
Start Date: 06/Feb/20 00:10
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10733: [BEAM-9229]
Adding dependency information to Environment proto
URL: https://github.com/apache/beam/pull/10733#discussion_r375573106
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1087,6 +1087,44 @@ message SideInput {
FunctionSpec window_mapping_fn = 3;
}
+message StandardArtifacts {
+ enum Types {
+ // A URN for artifacts stored in a local directory.
+ // payload: ArtifactFilePayload.
+ FILE = 0 [(beam_urn) = "beam:artifact:file:v1"];
+ // A URN for artifacts embedded in ArtifactInformation proto.
+ // payload: raw data bytes.
+ EMBEDDED = 1 [(beam_urn) = "beam:artifact:embedded:v1"];
+ // A URN for artifacts described by HTTP links.
+ // payload: a string for an artifact HTTP URL
+ HTTP = 2 [(beam_urn) = "beam:artifact:http:v1"];
+ // A URN for artifacts hosted on PYPI.
+ // artifact_id: a PYPI project name
+ // version_range: a PYPI compatible version string
+ // payload: None
+ PYPI = 3 [(beam_urn) = "beam:artifact:pypi:v1"];
+ // A URN for artifacts hosted on Maven central.
+ // artifact_id: [maven group id]:[maven artifact id]
+ // version_range: a Maven compatible version string
+ // payload: None
+ MAVEN = 4 [(beam_urn) = "beam:artifact:maven:v1"];
+ }
+}
+
+message ArtifactFilePayload {
+ // A path to an artifact file on a local system.
+ string local_path = 1;
+ // A generated staged name (no path).
+ string staged_name = 2;
+}
+
+message ArtifactInformation {
+ string urn = 1;
+ bytes payload = 2;
+ string artifact_id = 3;
Review comment:
It seems that payload and artifact_id are redundant. Merge them? Should
version-range be part of the payload as well? (Or, if it's a top-level
attribute, should it be in a standard format (not sure if there is one, but if
there is it'd be nice to be able to do generic intersections and merging...)).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 382611)
Time Spent: 40m (was: 0.5h)
> Adding dependency information to Environment proto
> --------------------------------------------------
>
> Key: BEAM-9229
> URL: https://issues.apache.org/jira/browse/BEAM-9229
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Adding dependency information to Environment proto.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
