[
https://issues.apache.org/jira/browse/BEAM-3301?focusedWorklogId=383030&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383030
]
ASF GitHub Bot logged work on BEAM-3301:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/20 18:48
Start Date: 06/Feb/20 18:48
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #10778: [BEAM-3301]
Small cleanup to KV Decoder.
URL: https://github.com/apache/beam/pull/10778#discussion_r376014767
##########
File path: sdks/go/pkg/beam/core/runtime/exec/coder.go
##########
@@ -304,8 +311,20 @@ func (c *kvDecoder) Decode(r io.Reader) (*FullValue,
error) {
if err != nil {
return nil, err
}
- return &FullValue{Elm: key.Elm, Elm2: value.Elm}, nil
+ return &FullValue{Elm: elideSingleElmFV(key), Elm2:
elideSingleElmFV(value)}, nil
+}
+// elideSingleElmFV elides a FullValue if it has only one element, returning
+// the contents of the first element, but returning the FullValue unchanged
+// if it has two elements.
+//
+// Technically drops window and timestamp info, so only use when those are
Review comment:
Great warning to include!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 383030)
Time Spent: 0.5h (was: 20m)
> Go SplittableDoFn support
> -------------------------
>
> Key: BEAM-3301
> URL: https://issues.apache.org/jira/browse/BEAM-3301
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> SDFs will be the only way to add streaming and liquid sharded IO for Go.
> Design doc: https://s.apache.org/splittable-do-fn
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
