[
https://issues.apache.org/jira/browse/BEAM-9262?focusedWorklogId=383099&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383099
]
ASF GitHub Bot logged work on BEAM-9262:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/20 19:32
Start Date: 06/Feb/20 19:32
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #10789: [BEAM-9262]
Clean-up endpoints.proto to a stable state
URL: https://github.com/apache/beam/pull/10789#discussion_r376032746
##########
File path: model/pipeline/src/main/proto/endpoints.proto
##########
@@ -28,20 +28,38 @@ option go_package = "pipeline_v1";
option java_package = "org.apache.beam.model.pipeline.v1";
option java_outer_classname = "Endpoints";
+// A description of how to connect to a Beam API endpoint.
message ApiServiceDescriptor {
// (Required) The URL to connect to.
- string url = 2;
+ string url = 1;
Review comment:
I assume this proto message isn't in common use yet, right? Because changing
the field number seems risky otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 383099)
Time Spent: 0.5h (was: 20m)
> Update ApiServiceDescriptor to have open ended authentication method
> --------------------------------------------------------------------
>
> Key: BEAM-9262
> URL: https://issues.apache.org/jira/browse/BEAM-9262
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently the ApiServiceDescriptor uses a oneof field for authentication
> which requires users to add additional types explicitly to the list instead
> of using urn + payload mechanism allowing for anyone to extend this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
