[ https://issues.apache.org/jira/browse/BEAM-9056?focusedWorklogId=383173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383173 ]
ASF GitHub Bot logged work on BEAM-9056: ---------------------------------------- Author: ASF GitHub Bot Created on: 06/Feb/20 21:41 Start Date: 06/Feb/20 21:41 Worklog Time Spent: 10m Work Description: chamikaramj commented on pull request #10621: [BEAM-9056] Staging artifacts from environment URL: https://github.com/apache/beam/pull/10621#discussion_r376091551 ########## File path: model/pipeline/src/main/proto/beam_runner_api.proto ########## @@ -1087,6 +1087,44 @@ message SideInput { FunctionSpec window_mapping_fn = 3; } +message StandardArtifacts { + enum Types { + // A URN for artifacts stored in a local directory. + // payload: ArtifactFilePayload. + FILE = 0 [(beam_urn) = "beam:artifact:file:v1"]; + // A URN for artifacts embedded in ArtifactInformation proto. + // payload: raw data bytes. + EMBEDDED = 1 [(beam_urn) = "beam:artifact:embedded:v1"]; + // A URN for artifacts described by HTTP links. + // payload: a string for an artifact HTTP URL + HTTP = 2 [(beam_urn) = "beam:artifact:http:v1"]; + // A URN for artifacts hosted on PYPI. + // artifact_id: a PYPI project name + // version_range: a PYPI compatible version string + // payload: None + PYPI = 3 [(beam_urn) = "beam:artifact:pypi:v1"]; + // A URN for artifacts hosted on Maven central. + // artifact_id: [maven group id]:[maven artifact id] + // version_range: a Maven compatible version string + // payload: None + MAVEN = 4 [(beam_urn) = "beam:artifact:maven:v1"]; + } +} + +message ArtifactFilePayload { + // A path to an artifact file on a local system. + string local_path = 1; + // A generated staged name (no path). + string staged_name = 2; Review comment: Can you elaborate what this is ? Also do bother of these get set or only one of them ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 383173) Time Spent: 0.5h (was: 20m) > Staging artifacts from environment > ---------------------------------- > > Key: BEAM-9056 > URL: https://issues.apache.org/jira/browse/BEAM-9056 > Project: Beam > Issue Type: Sub-task > Components: java-fn-execution > Reporter: Heejong Lee > Assignee: Heejong Lee > Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > staging artifacts from artifact information embedded in environment proto. > detail: > https://docs.google.com/document/d/1L7MJcfyy9mg2Ahfw5XPhUeBe-dyvAPMOYOiFA1-kAog -- This message was sent by Atlassian Jira (v8.3.4#803005)