[
https://issues.apache.org/jira/browse/BEAM-9241?focusedWorklogId=384624&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384624
]
ASF GitHub Bot logged work on BEAM-9241:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/20 18:15
Start Date: 10/Feb/20 18:15
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on pull request #10746:
[BEAM-9241] Fix inconsistent proto nullability
URL: https://github.com/apache/beam/pull/10746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 384624)
Time Spent: 1h 40m (was: 1.5h)
> Fix inconsistent nullability mapping for Protobuf to Schema
> -----------------------------------------------------------
>
> Key: BEAM-9241
> URL: https://issues.apache.org/jira/browse/BEAM-9241
> Project: Beam
> Issue Type: Bug
> Components: extensions-java-protobuf
> Affects Versions: 2.18.0
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Fix the nullability issues with protobuf to schema mapping
> * Proto3 primitive types should be *not* nullable.
> * Proto2 required types should be *not* nullable.
> * Proto2 optional should also be *not* nullable as having an optional value
> doesn't mean it has not value. The spec states it has the optional value.
> * Arrays should be *not* nullable, as proto arrays always have an empty
> array when no value is set.
> * Maps should be *not* nullable, as proto maps always have an empty map when
> no value is set.
> * Elements in an array should be *not* nullable, as nulls are not allowed in
> an array.
> * Names and Values should be *not* nullable, as nulls are not allowed.
> * Rows are nullable, as messages are nullable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
