[
https://issues.apache.org/jira/browse/BEAM-8889?focusedWorklogId=384661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384661
]
ASF GitHub Bot logged work on BEAM-8889:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/20 19:17
Start Date: 10/Feb/20 19:17
Worklog Time Spent: 10m
Work Description: suztomo commented on issue #10769: [BEAM-8889] Upgrades
gcsio to 2.0.0
URL: https://github.com/apache/beam/pull/10769#issuecomment-584303317
(I'm not a committer and cannot approve this PR)
Right. I agree that Guava cannot be upgraded at the moment.
Regarding the risk of [the three
classes](https://gist.github.com/veblush/a9470a977ed8dfa2f3e94f4c9f3957c7#file-gistfile1-txt-L62)(`com.google.cloud.hadoop.gcsio.cooplock.CoopLockOperationDao`,
`com.google.cloud.hadoop.gcsio.testing.InMemoryObjectEntry`, and
`com.google.cloud.hadoop.gcsio.cooplock.CoopLockRecordsDao`) that use the
missing methods in Guava 25.
- if the classes are unused in Beam users' environment, it shouldn't be a
problem.
- if they are used by Beam users environment (even for other purposes than
Beam uses), then it will cause the problem to the users.
- The package "gcsio.testing" sounds testing. This doesn't seem bother
Beam users unless they test their system using the class.
- "gcsio.cooplock" seems for Cloud Storage Connector for Hadoop's
[Cooperative
locking](https://cloud.google.com/blog/products/data-analytics/new-release-of-cloud-storage-connector-for-hadoop-improving-performance-throughput-and-more)
- In future, Beam or Beam's dependency may touch the class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 384661)
Remaining Estimate: 155h 40m (was: 155h 50m)
Time Spent: 12h 20m (was: 12h 10m)
> Make GcsUtil use GoogleCloudStorage
> -----------------------------------
>
> Key: BEAM-8889
> URL: https://issues.apache.org/jira/browse/BEAM-8889
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Affects Versions: 2.16.0
> Reporter: Esun Kim
> Assignee: VASU NORI
> Priority: Major
> Labels: gcs
> Original Estimate: 168h
> Time Spent: 12h 20m
> Remaining Estimate: 155h 40m
>
> [GcsUtil|https://github.com/apache/beam/blob/master/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java]
> is a primary class to access Google Cloud Storage on Apache Beam. Current
> implementation directly creates GoogleCloudStorageReadChannel and
> GoogleCloudStorageWriteChannel by itself to read and write GCS data rather
> than using
> [GoogleCloudStorage|https://github.com/GoogleCloudPlatform/bigdata-interop/blob/master/gcsio/src/main/java/com/google/cloud/hadoop/gcsio/GoogleCloudStorage.java]
> which is an abstract class providing basic IO capability which eventually
> creates channel objects. This request is about updating GcsUtil to use
> GoogleCloudStorage to create read and write channel, which is expected
> flexible because it can easily pick up the new change; e.g. new channel
> implementation using new protocol without code change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
