[ 
https://issues.apache.org/jira/browse/BEAM-5605?focusedWorklogId=384826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384826
 ]

ASF GitHub Bot logged work on BEAM-5605:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Feb/20 23:12
            Start Date: 10/Feb/20 23:12
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on pull request #10576: [BEAM-5605] 
Convert all BoundedSources to SplittableDoFns when using beam_fn_api experiment.
URL: https://github.com/apache/beam/pull/10576#discussion_r377372981
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
 ##########
 @@ -94,6 +106,20 @@ private Bounded(@Nullable String name, BoundedSource<T> 
source) {
     public final PCollection<T> expand(PBegin input) {
       source.validate();
 
+      if (ExperimentalOptions.hasExperiment(input.getPipeline().getOptions(), 
"beam_fn_api")) {
 
 Review comment:
   I was able to remove JavaReadViaImpulse. It required fixing up some tests 
that weren't setting the `beam_fn_api` experiment.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 384826)
    Time Spent: 11h 50m  (was: 11h 40m)

> Support Portable SplittableDoFn for batch
> -----------------------------------------
>
>                 Key: BEAM-5605
>                 URL: https://issues.apache.org/jira/browse/BEAM-5605
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Assignee: Luke Cwik
>            Priority: Major
>              Labels: portability
>          Time Spent: 11h 50m
>  Remaining Estimate: 0h
>
> Roll-up item tracking work towards supporting portable SplittableDoFn for 
> batch



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to