[
https://issues.apache.org/jira/browse/BEAM-8350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035744#comment-17035744
]
Udi Meiri commented on BEAM-8350:
---------------------------------
Seems resolved. Closing
> Upgrade to pylint 2.4
> ---------------------
>
> Key: BEAM-8350
> URL: https://issues.apache.org/jira/browse/BEAM-8350
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
> pylint 2.4 provides a number of new features and fixes, but the most
> important/pressing one for me is that 2.4 adds support for understanding
> python type annotations, which fixes a bunch of spurious unused import errors
> in the PR I'm working on for BEAM-7746.
> As of 2.0, pylint dropped support for running tests in python2, so to make
> the upgrade we have to move our lint jobs to python3. Doing so will put
> pylint into "python3-mode" and there is not an option to run in
> python2-compatible mode. That said, the beam code is intended to be python3
> compatible, so in practice, performing a python3 lint on the Beam code-base
> is perfectly safe. The primary risk of doing this is that someone introduces
> a python-3 only change that breaks python2, but these would largely be syntax
> errors that would be immediately caught by the unit and integration tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
