[
https://issues.apache.org/jira/browse/BEAM-9211?focusedWorklogId=387077&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387077
]
ASF GitHub Bot logged work on BEAM-9211:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/20 03:00
Start Date: 14/Feb/20 03:00
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #10723: [BEAM-9211]
upload missing Spark portable jar test script
URL: https://github.com/apache/beam/pull/10723#discussion_r379229678
##########
File path: runners/portability/test_pipeline_jar.sh
##########
@@ -28,6 +28,16 @@ case $key in
shift # past argument
shift # past value
;;
+ --spark_job_server_jar)
Review comment:
I see, but will it not be a bit confusing to only specify one of these
option at a time.
Like this gives the user option to provide flink runner but also provide
spark_job_server_jar.
I don;t have a strong opinion on this so its upto you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 387077)
Time Spent: 2.5h (was: 2h 20m)
> Spark portable jar test script is missing
> -----------------------------------------
>
> Key: BEAM-9211
> URL: https://issues.apache.org/jira/browse/BEAM-9211
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Labels: portability-spark
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> beam_PostCommit_PortableJar_Spark has been failing since its creation because
> I forgot to upload the test script it calls. Whoops.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
