[
https://issues.apache.org/jira/browse/BEAM-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036700#comment-17036700
]
sunjincheng commented on BEAM-9299:
-----------------------------------
I found that the issue FLINK-15844 also exists in Flink 1.8.3. I noticed that
FLINK-15844 has provided a fix for 1.9.3. However, AFAIK, there will be no new
1.8 releases any more according to FLink's [release
policy|[https://flink.apache.org/downloads.html#update-policy-for-old-releases]].
There are two solutions in my mind:
- Solution1: As the signature of `JobWithJars.buildUserCodeClassLoader `has
changed in both Flink 1.8.3 and 1.9.2 and Flink 1.7.2 still uses the old
signature, we could drop the Flink 1.7 support firstly and then update the
implementation of `FlinkExecutionEnvironments` to use the new signature.
-Solution2: We could make a copy of `FlinkExecutionEnvironments` in each
version of Flink runner and update the implementation for each copy according
to the Flink version. This solution decouples the drop of Flink 1.7 support and
the upgrades of 1.8 and 1.9. Besides, Flink community has made big change for
the job submission path(FLINK-13954) in 1.10, e.g. `JobWithJars` has been
removed in 1.10. It means that the job submission logic will be separate for
1.8/1.9 and 1.10 anyway.
Personally I prefer solution2 and what's your thought? :)
> Upgrade Flink Runner to 1.8.3 and 1.9.2
> ---------------------------------------
>
> Key: BEAM-9299
> URL: https://issues.apache.org/jira/browse/BEAM-9299
> Project: Beam
> Issue Type: Task
> Components: runner-flink
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I would like to Upgrade Flink Runner to 18.3 and 1.9.2 due to both the Apache
> Flink 1.8.3 and Apache Flink 1.9.2 have been released [1].
> What do you think?
> [1] https://dist.apache.org/repos/dist/release/flink/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
