[
https://issues.apache.org/jira/browse/BEAM-9301?focusedWorklogId=387326&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387326
]
ASF GitHub Bot logged work on BEAM-9301:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/20 12:41
Start Date: 14/Feb/20 12:41
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #10841: [BEAM-9301] Check in
beam-linkage-check.sh
URL: https://github.com/apache/beam/pull/10841#issuecomment-586271961
In the last part of the script we do `git checkout master` just to compare,
however if master is already checked out in a different which can happen if you
use `git worktree`s the script breaks losing all the previous work.
I think we can avoid the validation and make the script more robust by not
checking master but the hash that corresponds to master. I opened #10865 to
tackle this, PTAL @suztomo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 387326)
Time Spent: 1.5h (was: 1h 20m)
> Add a script to check Java linkage issues (beam-linkage-check.sh)
> -----------------------------------------------------------------
>
> Key: BEAM-9301
> URL: https://issues.apache.org/jira/browse/BEAM-9301
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Tomo Suzuki
> Assignee: Tomo Suzuki
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> https://github.com/apache/beam/pull/10769#issuecomment-584571787
> bq. @suztomo can you contribute this script maybe into Beam's build-tools
> directory so we can improve it a bit for further use?
> This is a temporary solution before exclusion rules in Linkage Checker
> (BEAM-9206) are implemented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
