[
https://issues.apache.org/jira/browse/BEAM-9311?focusedWorklogId=387511&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387511
]
ASF GitHub Bot logged work on BEAM-9311:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/20 17:52
Start Date: 14/Feb/20 17:52
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #10855: [BEAM-9311]
ZetaSQL Named Parameters are case-insensitive
URL: https://github.com/apache/beam/pull/10855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 387511)
Time Spent: 0.5h (was: 20m)
> ZetaSQL Named Parameters are lower case, don't treat as case-sensitive
> ----------------------------------------------------------------------
>
> Key: BEAM-9311
> URL: https://issues.apache.org/jira/browse/BEAM-9311
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> ZetaSQL Named Parameters are case insensitive, always resolved to lower case.
> See:
> https://github.com/google/zetasql/blob/79adcd0fe227173e68ed7aa88f580a691ebe82c2/zetasql/analyzer/resolver_expr.cc#L1342
> java.lang.NullPointerException at
> org.apache.beam.sdk.extensions.sql.zetasql.translation.ExpressionConverter.convertResolvedParameter(ExpressionConverter.java:962)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.translation.ExpressionConverter.convertRexNodeFromResolvedExpr(ExpressionConverter.java:311)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.translation.ExpressionConverter.convertRexNodeFromComputedColumnWithFieldList(ExpressionConverter.java:460)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.translation.ExpressionConverter.retrieveRexNode(ExpressionConverter.java:207)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.translation.ProjectScanConverter.convert(ProjectScanConverter.java:45)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.translation.ProjectScanConverter.convert(ProjectScanConverter.java:29)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.translation.QueryStatementConverter.convertNode(QueryStatementConverter.java:97)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.translation.QueryStatementConverter.convert(QueryStatementConverter.java:84)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.translation.QueryStatementConverter.convertRootQuery(QueryStatementConverter.java:51)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLPlannerImpl.rel(ZetaSQLPlannerImpl.java:160)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner.convertToBeamRelInternal(ZetaSQLQueryPlanner.java:131)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner.convertToBeamRel(ZetaSQLQueryPlanner.java:115)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner.convertToBeamRel(ZetaSQLQueryPlanner.java:103)
> at
> org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLDialectSpecTest.testNamedParameterQuery(ZetaSQLDialectSpecTest.java:3245)
>
> Repro:
>
> {code:java}
> @Test
> public void testNamedParameterQuery() {
> String sql = "SELECT @ColA AS ColA";
> ImmutableMap<String, Value> params = ImmutableMap.of("ColA",
> Value.createInt64Value(5));
> ZetaSQLQueryPlanner zetaSQLQueryPlanner = new ZetaSQLQueryPlanner(config);
> BeamRelNode beamRelNode = zetaSQLQueryPlanner.convertToBeamRel(sql, params);
> PCollection<Row> stream = BeamSqlRelUtils.toPCollection(pipeline,
> beamRelNode);
> final Schema schema = Schema.builder().addInt64Field("field1").build();
>
> PAssert.that(stream).containsInAnyOrder(Row.withSchema(schema).addValues(5L).build());
>
> pipeline.run().waitUntilFinish(Duration.standardMinutes(PIPELINE_EXECUTION_WAITTIME_MINUTES));
> }
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
