[
https://issues.apache.org/jira/browse/BEAM-8889?focusedWorklogId=387531&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387531
]
ASF GitHub Bot logged work on BEAM-8889:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/20 18:10
Start Date: 14/Feb/20 18:10
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10857: [BEAM-8889]
Upgrade guava to 28.0-jre
URL: https://github.com/apache/beam/pull/10857#discussion_r379572003
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -383,7 +383,7 @@ class BeamModulePlugin implements Plugin<Project> {
def google_cloud_spanner_version = "1.49.1"
def google_http_clients_version = "1.34.0"
def grpc_version = "1.25.0"
- def guava_version = "25.1-jre"
+ def guava_version = "28.0-jre"
Review comment:
Either is fine, if all the tests and work were done to update to 28.0-jre
have been done then it makes sense to go with 28.0-jre. But if there is a bunch
of investigation that is necessary. Then its up to the PR author to choose
whether they want to restart the tests/validation from 28.2-jre.
As a reviewer, I would be happy with either the 28.0-jre or 28.2-jre upgrade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 387531)
Remaining Estimate: 150h 20m (was: 150.5h)
Time Spent: 17h 40m (was: 17.5h)
> Make GcsUtil use GoogleCloudStorage
> -----------------------------------
>
> Key: BEAM-8889
> URL: https://issues.apache.org/jira/browse/BEAM-8889
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Affects Versions: 2.16.0
> Reporter: Esun Kim
> Assignee: VASU NORI
> Priority: Major
> Labels: gcs
> Original Estimate: 168h
> Time Spent: 17h 40m
> Remaining Estimate: 150h 20m
>
> [GcsUtil|https://github.com/apache/beam/blob/master/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java]
> is a primary class to access Google Cloud Storage on Apache Beam. Current
> implementation directly creates GoogleCloudStorageReadChannel and
> GoogleCloudStorageWriteChannel by itself to read and write GCS data rather
> than using
> [GoogleCloudStorage|https://github.com/GoogleCloudPlatform/bigdata-interop/blob/master/gcsio/src/main/java/com/google/cloud/hadoop/gcsio/GoogleCloudStorage.java]
> which is an abstract class providing basic IO capability which eventually
> creates channel objects. This request is about updating GcsUtil to use
> GoogleCloudStorage to create read and write channel, which is expected
> flexible because it can easily pick up the new change; e.g. new channel
> implementation using new protocol without code change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
