[
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=389226&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389226
]
ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/20 00:35
Start Date: 19/Feb/20 00:35
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10886: [BEAM-8019]
Updates DataflowRunner to support multiple SDK environments.
URL: https://github.com/apache/beam/pull/10886#discussion_r381008681
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -478,6 +544,19 @@ def __init__(self, options):
get_credentials=(not self.google_cloud_options.no_auth),
http=http_client,
response_encoding=get_response_encoding())
+ self._sdk_image_overrides = self._get_sdk_image_overrides(options)
+
+ def _get_sdk_image_overrides(self, pipeline_options):
+ worker_options = pipeline_options.view_as(WorkerOptions)
+ sdk_overrides = worker_options.sdk_harness_container_image_overrides
+ overrides_dict = dict()
Review comment:
Again, one can write
`overrides_dict = dict(override_str.split(',', 1) for override_str in
sdk_overrides)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 389226)
Time Spent: 4h (was: 3h 50m)
> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-8019
> URL: https://issues.apache.org/jira/browse/BEAM-8019
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
