[
https://issues.apache.org/jira/browse/BEAM-9326?focusedWorklogId=389658&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389658
]
ASF GitHub Bot logged work on BEAM-9326:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/20 22:14
Start Date: 19/Feb/20 22:14
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #10879: [BEAM-9326] Make
JsonToRow transform input <String> instead of <? extends String>
URL: https://github.com/apache/beam/pull/10879#issuecomment-588499498
Yikes! If removing `<? extends String>` makes it impossible to treat this
class as a `PTransform` then I think this change should be reverted. Indeed I
wondered if there was something funky going to happy in Java's type checking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 389658)
Time Spent: 1h (was: 50m)
> JsonToRow transform should not use bounded Wildcards for its input
> ------------------------------------------------------------------
>
> Key: BEAM-9326
> URL: https://issues.apache.org/jira/browse/BEAM-9326
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.20.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The JsonToRow PTransform input is a String (a final class in Java) so no
> reason
> to define a bounded wildcard as its argument.
> We should use <? extends String> in Beam's codebase only when required by Java
> Generics constraints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
