[ 
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=389667&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389667
 ]

ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Feb/20 22:49
            Start Date: 19/Feb/20 22:49
    Worklog Time Spent: 10m 
      Work Description: KevinGG commented on pull request #10899: [BEAM-8335] 
Background Caching job
URL: https://github.com/apache/beam/pull/10899#discussion_r381592605
 
 

 ##########
 File path: 
sdks/python/apache_beam/runners/interactive/interactive_environment.py
 ##########
 @@ -130,6 +139,17 @@ def __init__(self, cache_manager=None):
           'You have limited Interactive Beam features since your '
           'ipython kernel is not connected any notebook frontend.')
 
+  @property
+  def options(self):
+    """A reference to the global interactive options.
+
+    Provided to avoid import loop or excessive dynamic import. All internal
+    Interactive Beam modules should access interactive_beam.options through
+    this property.
+    """
+    from apache_beam.runners.interactive.interactive_beam import options
+    return options
 
 Review comment:
   The `options` instantiated in `interactive_beam` is to expose the `getters` 
and `setters` of configurable fields such as `enable_capture_replay`, 
`capture_duration` and `capturable_sources` to the `interactive beam` user.
   The user has all necessary `getters`, `setters` and docstrings by looking at 
the `interactive_beam` module without the complexity of their underlying 
implementation details (such as `__repr__`, and how options and their utilities 
are grouped together).
   
   Then inside all internal `interactive beam` modules, to access the fields 
configured by the user, since we don't want any module to depend on 
`interactive_beam` module to avoid import loops, we can only do dynamic 
importing. It's going to be messy if we just dynamic import `interactive_beam` 
(the module that is supposed to be used by end user) everywhere. So this 
property (no `setter` given) does the dynamic import once in this single place 
and all internal modules will depend on `interactive_environment` module to 
access whatever configuration the user might have set.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 389667)
    Time Spent: 64h 50m  (was: 64h 40m)

> Add streaming support to Interactive Beam
> -----------------------------------------
>
>                 Key: BEAM-8335
>                 URL: https://issues.apache.org/jira/browse/BEAM-8335
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-py-interactive
>            Reporter: Sam Rohde
>            Assignee: Sam Rohde
>            Priority: Major
>          Time Spent: 64h 50m
>  Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the 
> Interactive Beam experience. This will allow users to:
>  * Write and run a streaming job in IPython
>  * Automatically cache records from unbounded sources
>  * Add a replay experience that replays all cached records to simulate the 
> original pipeline execution
>  * Add controls to play/pause/stop/step individual elements from the cached 
> records
>  * Add ability to inspect/visualize unbounded PCollections



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to