[
https://issues.apache.org/jira/browse/BEAM-5605?focusedWorklogId=390125&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390125
]
ASF GitHub Bot logged work on BEAM-5605:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/20 18:07
Start Date: 20/Feb/20 18:07
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10893: [BEAM-5605]
Honor the bounded source timestamps timestamp in the SDF wrapper.
URL: https://github.com/apache/beam/pull/10893#discussion_r382168112
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java
##########
@@ -242,18 +243,19 @@ public void splitRestriction(
}
@NewTracker
- public RestrictionTracker<BoundedSource<T>, Object[]> restrictionTracker(
+ public RestrictionTracker<BoundedSource<T>, TimestampedValue<T>[]>
restrictionTracker(
@Restriction BoundedSource<T> restriction, PipelineOptions
pipelineOptions) {
return new BoundedSourceAsSDFRestrictionTracker<>(restriction,
pipelineOptions);
}
@ProcessElement
public void processElement(
- RestrictionTracker<BoundedSource<T>, Object[]> tracker,
OutputReceiver<T> receiver)
+ RestrictionTracker<BoundedSource<T>, TimestampedValue<T>[]> tracker,
+ OutputReceiver<T> receiver)
throws IOException {
- Object[] out = new Object[1];
+ TimestampedValue<T>[] out = new TimestampedValue[1];
while (tracker.tryClaim(out)) {
- receiver.output((T) out[0]);
+ receiver.outputWithTimestamp(out[0].getValue(), out[0].getTimestamp());
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 390125)
Time Spent: 16.5h (was: 16h 20m)
> Support Portable SplittableDoFn for batch
> -----------------------------------------
>
> Key: BEAM-5605
> URL: https://issues.apache.org/jira/browse/BEAM-5605
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Scott Wegner
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 16.5h
> Remaining Estimate: 0h
>
> Roll-up item tracking work towards supporting portable SplittableDoFn for
> batch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
