[
https://issues.apache.org/jira/browse/BEAM-9331?focusedWorklogId=390247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390247
]
ASF GitHub Bot logged work on BEAM-9331:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/20 20:32
Start Date: 20/Feb/20 20:32
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on pull request #10883:
[BEAM-9331] Add better Row builders
URL: https://github.com/apache/beam/pull/10883#discussion_r382241904
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/values/RowTest.java
##########
@@ -477,6 +477,172 @@ public void testCreateMapWithRowValue() {
assertEquals(data, row.getMap("map"));
}
+ @Test
Review comment:
What about this,
- `addValue`, `getValue` and `getValues` return the input type(s) (so the
logical type)
- `add`, `get`, `detach` returns the base types (is also inline with the
`attach`)
That means a behaviour change only for `getValue` and `getValues`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 390247)
Time Spent: 2h 50m (was: 2h 40m)
> The Row object needs better builders
> ------------------------------------
>
> Key: BEAM-9331
> URL: https://issues.apache.org/jira/browse/BEAM-9331
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Users should be able to build a Row object by specifying field names. Desired
> syntax:
>
> Row.withSchema(schema)
> .withFieldName("field1", "value)
> .withFieldName("field2.field3", value)
> .build()
>
> Users should also have a builder that allows taking an existing row and
> changing specific fields.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
