[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=391487&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-391487
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/20 03:02
Start Date: 24/Feb/20 03:02
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #10502: [BEAM-7274]
Add DynamicMessage Schema support
URL: https://github.com/apache/beam/pull/10502#discussion_r383070050
##########
File path:
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoDomain.java
##########
@@ -163,15 +163,15 @@ private void indexDescriptorByName() {
.values()
.forEach(
fileDescriptor -> {
- fileDescriptor
- .getMessageTypes()
- .forEach(
- descriptor -> {
- descriptorMap.put(descriptor.getFullName(),
descriptor);
- });
+ fileDescriptor.getMessageTypes().forEach(descriptor ->
indexDescriptor(descriptor));
Review comment:
I think you can replace the lambda with this::indexDescriptor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 391487)
Time Spent: 24h 50m (was: 24h 40m)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Fix For: 2.20.0
>
> Time Spent: 24h 50m
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
