[
https://issues.apache.org/jira/browse/BEAM-9345?focusedWorklogId=392040&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392040
]
ASF GitHub Bot logged work on BEAM-9345:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/20 19:56
Start Date: 24/Feb/20 19:56
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #10950: [BEAM-9345] Add
end-to-end Flink job submission test
URL: https://github.com/apache/beam/pull/10950#discussion_r383470467
##########
File path:
runners/flink/1.7/src/test/java/org/apache/beam/runners/flink/RemoteMiniClusterImpl.java
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.flink;
+
+import akka.actor.ActorSystem;
+import com.typesafe.config.Config;
+import org.apache.flink.api.common.time.Time;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.runtime.akka.AkkaUtils;
+import org.apache.flink.runtime.minicluster.MiniCluster;
+import org.apache.flink.runtime.minicluster.MiniClusterConfiguration;
+import org.apache.flink.runtime.rpc.RpcService;
+import org.apache.flink.runtime.rpc.akka.AkkaRpcService;
+
+/** A {@link MiniCluster} which allows remote connections for the end-to-end
test. */
+public class RemoteMiniClusterImpl extends RemoteMiniCluster {
+
+ private int port = -1;
+
+ public RemoteMiniClusterImpl(MiniClusterConfiguration
miniClusterConfiguration) {
+ super(miniClusterConfiguration);
+ }
+
+ @Override
+ protected RpcService createRpcService(
+ Configuration configuration, Time askTimeout, boolean remoteEnabled,
String bindAddress) {
+
+ // Enable remote connections to the mini cluster which are disabled by
default
+ final Config akkaConfig = AkkaUtils.getAkkaConfig(configuration,
"localhost", 0);
+
+ final Config effectiveAkkaConfig =
AkkaUtils.testDispatcherConfig().withFallback(akkaConfig);
+
+ final ActorSystem actorSystem =
AkkaUtils.createActorSystem(effectiveAkkaConfig);
+
+ AkkaRpcService akkaRpcService = new AkkaRpcService(actorSystem,
askTimeout);
+ this.port = akkaRpcService.getPort();
+
+ return akkaRpcService;
+ }
+
+ @Override
+ public int getClusterPort() {
+ return port;
Review comment:
This method will return -1 if createRpcService has not been called. Maybe we
should add an assertion here to prevent that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 392040)
Time Spent: 0.5h (was: 20m)
> "Multiple environments cannot be created in detached mode"
> ----------------------------------------------------------
>
> Key: BEAM-9345
> URL: https://issues.apache.org/jira/browse/BEAM-9345
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Kyle Weaver
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Workarounds.restoreOriginalStdOutAndStdErrIfApplicable throws exception when
> running in standalone session cluster. Since FLINK-15504 is resolved in Flink
> 1.10, maybe we can remove the workaround in Beam?
> From user@
> (https://lists.apache.org/thread.html/r1fb9456055ae51f998be67531f0ac55d3da9cf2647238b991eee7f97%40%3Cuser.beam.apache.org%3E):
> I am trying to upgrade from a Flink session cluster 1.8 to 1.9 and from Beam
> 2.16.0 to 2.19.0.
> Everything went quite smoothly, the local runner and the local Flink runner
> work flawlessly.
> However when I:
> 1. Generate a Beam jar for the FlinkRunner via maven (mvn package
> -PFlinkRunner)
> 2. Glue that into a Flink 1.9 docker image
> 3. Start the image as a Standalone Session Cluster
> When I try to launch the first pipeline I get the following exception
> {noformat}
> org.apache.flink.client.program.ProgramInvocationException: The main method
> caused an error: Failed to construct instance from factory method
> FlinkRunner#fromOptions(interface org.apache.beam.sdk.options.PipelineOptions)
> at
> org.apache.flink.client.program.PackagedProgram.callMainMethod(PackagedProgram.java:593)
> at
> org.apache.flink.client.program.PackagedProgram.invokeInteractiveModeForExecution(PackagedProgram.java:438)
> at
> org.apache.flink.client.program.ClusterClient.run(ClusterClient.java:274)
> at
> org.apache.flink.client.cli.CliFrontend.executeProgram(CliFrontend.java:746)
> at
> org.apache.flink.client.cli.CliFrontend.runProgram(CliFrontend.java:273)
> at org.apache.flink.client.cli.CliFrontend.run(CliFrontend.java:205)
> at
> org.apache.flink.client.cli.CliFrontend.parseParameters(CliFrontend.java:1010)
> at
> org.apache.flink.client.cli.CliFrontend.lambda$main$10(CliFrontend.java:1083)
> at
> org.apache.flink.runtime.security.NoOpSecurityContext.runSecured(NoOpSecurityContext.java:30)
> at org.apache.flink.client.cli.CliFrontend.main(CliFrontend.java:1083)
> Caused by: java.lang.RuntimeException: Failed to construct instance from
> factory method FlinkRunner#fromOptions(interface
> org.apache.beam.sdk.options.PipelineOptions)
> at
> org.apache.beam.sdk.util.InstanceBuilder.buildFromMethod(InstanceBuilder.java:224)
> at
> org.apache.beam.sdk.util.InstanceBuilder.build(InstanceBuilder.java:155)
> at
> org.apache.beam.sdk.PipelineRunner.fromOptions(PipelineRunner.java:55)
> at org.apache.beam.sdk.Pipeline.run(Pipeline.java:309)
> at org.apache.beam.sdk.Pipeline.run(Pipeline.java:301)
> at ch.ricardo.di.beam.KafkaToBigQuery.main(KafkaToBigQuery.java:180)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.flink.client.program.PackagedProgram.callMainMethod(PackagedProgram.java:576)
> ... 9 more
> Caused by: java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.beam.sdk.util.InstanceBuilder.buildFromMethod(InstanceBuilder.java:214)
> ... 19 more
> Caused by: org.apache.flink.api.common.InvalidProgramException: Multiple
> environments cannot be created in detached mode
> at
> org.apache.flink.client.program.ContextEnvironmentFactory.createExecutionEnvironment(ContextEnvironmentFactory.java:67)
> at java.util.Optional.map(Optional.java:215)
> at
> org.apache.flink.api.java.ExecutionEnvironment.getExecutionEnvironment(ExecutionEnvironment.java:1068)
> at
> org.apache.beam.runners.flink.translation.utils.Workarounds.restoreOriginalStdOutAndStdErrIfApplicable(Workarounds.java:43)
> at
> org.apache.beam.runners.flink.FlinkRunner.<init>(FlinkRunner.java:96)
> at
> org.apache.beam.runners.flink.FlinkRunner.fromOptions(FlinkRunner.java:90)
> ... 24 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
