[
https://issues.apache.org/jira/browse/BEAM-9162?focusedWorklogId=392078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392078
]
ASF GitHub Bot logged work on BEAM-9162:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/20 20:36
Start Date: 24/Feb/20 20:36
Worklog Time Spent: 10m
Work Description: suztomo commented on issue #10643: [BEAM-9162] Upgrade
Jackson to version 2.10.2
URL: https://github.com/apache/beam/pull/10643#issuecomment-590536381
@iemejia How about running diff command while waiting for the result? (The
script outputs the file name).
I thought about the comparing the result early (see "Early Exist on Failure"
below) but it would increase overall execution time.
## Current
As of now the script consists of (1) Install artifacts and (2) run multiple
checkJavaLinakge, for 2 branches.
```
for branch in [master, PR]:
install artifacts // This takes ~ 5 minutes
for beamArtifact in ["beam-sdks-java-core",
"beam-sdks-java-io-google-cloud-platform" ... ]
checkJavaLinkage beamArtifact // This takes 1 ~ 4 minutes
compare_diff
```
Total time for "install artifacts" is ~10 minutes (2 * 5)
## Early Exit on Failure
I considered changing the loop order as below, but the number of "install
artifacts" increases if the for-loop for the Beam artifacts is outside:
```
for beamArtifact in ["beam-sdks-java-core",
"beam-sdks-java-io-google-cloud-platform", "beam-runners-google-cloud-dataflow"
]:
for branch in [master, PR]:
install artifacts // This takes ~ 5 minutes
checkJavaLinkage beamArtifact // This takes 1 ~ 4 minutes
compare_diff
```
Total time for "install artifacts" is ~30 minutes (3 * 2 * 5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 392078)
Time Spent: 5.5h (was: 5h 20m)
> Upgrade Jackson to version 2.10.2
> ---------------------------------
>
> Key: BEAM-9162
> URL: https://issues.apache.org/jira/browse/BEAM-9162
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.20.0
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Jackson has a new way to deal with [deserialization security
> issues|https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.10] in
> 2.10.x so worth the upgrade.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
