[
https://issues.apache.org/jira/browse/BEAM-9296?focusedWorklogId=392144&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392144
]
ASF GitHub Bot logged work on BEAM-9296:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/20 22:58
Start Date: 24/Feb/20 22:58
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #10935: [BEAM-9296]
Clean up and add type-hints to SDF API
URL: https://github.com/apache/beam/pull/10935#discussion_r383564824
##########
File path: sdks/python/apache_beam/runners/common.py
##########
@@ -333,6 +336,7 @@ def is_splittable_dofn(self):
return self.get_restriction_provider() is not None
def get_restriction_coder(self):
+ # type: () -> Optional[TupleCoder]
Review comment:
Done. I think the return type should still be `Optional[TupleCoder]` given
that it also returns `None`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 392144)
Time Spent: 40m (was: 0.5h)
> Add typing annotation to python SDF
> -----------------------------------
>
> Key: BEAM-9296
> URL: https://issues.apache.org/jira/browse/BEAM-9296
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core, sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
