[
https://issues.apache.org/jira/browse/BEAM-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044052#comment-17044052
]
Rahul Patwari commented on BEAM-9240:
-------------------------------------
Hi [~amaliujia],
I have committed the required changes to fix the bug. The review is pending
though.
I have added you as a reviewer. Can you please review and merge the PR. If not,
can you suggest other committers that I can add as a reviewer?
I have raised the bug before 2.19.0 release, but couldn't commit the required
changes. I would prefer to fix the bug with 2.20.0 release. If the PR cannot be
merged by then, it can be pushed back to 2.21.0.
> Check for Nullability in typesEqual() method of FieldType class
> ---------------------------------------------------------------
>
> Key: BEAM-9240
> URL: https://issues.apache.org/jira/browse/BEAM-9240
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Affects Versions: 2.18.0
> Reporter: Rahul Patwari
> Assignee: Rahul Patwari
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> {{If two schemas are created like this:}}
> {{Schema schema1 = Schema.builder().addStringField("col1").build();}}
> {{Schema schema2 = Schema.builder().addNullableField("col1",
> FieldType.STRING).build();}}
>
> {{schema1.typeEquals(schema2) returns "true" even though the schemas differ
> by Nullability}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
