[
https://issues.apache.org/jira/browse/BEAM-9295?focusedWorklogId=392597&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392597
]
ASF GitHub Bot logged work on BEAM-9295:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/20 14:49
Start Date: 25/Feb/20 14:49
Worklog Time Spent: 10m
Work Description: sunjincheng121 commented on issue #10945: [BEAM-9295]
Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10
URL: https://github.com/apache/beam/pull/10945#issuecomment-590903651
> There a large amount of code duplication. Is that really necessary? AFAIK
the changes between 1.9 and 1.10 should be minimal. Could you please revise
this or explain why it is necessary?
There are a lot of changes related to the job client
API(https://issues.apache.org/jira/browse/FLINK-14392,
https://issues.apache.org/jira/browse/FLINK-14376) in 1.10. I have added
comments at the header of each test case copied to 1.10 for the reason making a
copy of them. Could you help to take a look at if the reason makes sense for
you? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 392597)
Time Spent: 1h 20m (was: 1h 10m)
> Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10
> ---------------------------------------------------------------------------
>
> Key: BEAM-9295
> URL: https://issues.apache.org/jira/browse/BEAM-9295
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Apache Flink 1.10 has completed the final release vote, see [1]. So, I would
> like to add Flink 1.10 build target and make Flink Runner compatible with
> Flink 1.10.
> And I appreciate it if you can leave your suggestions or comments!
> [1]
> https://lists.apache.org/thread.html/r97672d4d1e47372cebf23e6643a6cc30a06bfbdf3f277b0be3695b15%40%3Cdev.flink.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
