[
https://issues.apache.org/jira/browse/BEAM-9247?focusedWorklogId=393234&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-393234
]
ASF GitHub Bot logged work on BEAM-9247:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/20 08:13
Start Date: 26/Feb/20 08:13
Worklog Time Spent: 10m
Work Description: EDjur commented on issue #10959: [BEAM-9247] Integrate
GCP Vision API functionality
URL: https://github.com/apache/beam/pull/10959#issuecomment-591295088
> Cool, nice to hear that!
>
> One more thing that came to my mind.
> Would it be possible to merge `AnnotateImage` and `BatchAnnotateImage`
transforms? I think the user has little interest in configuring
`min_batch_size` and `max_batch_size`, because, at the end, responses are
flatten (output PCollection is of type `AnnotateImageResponse`, not
`List[AnnotateImageResponse]`). Also, I expect that `batch_annotate_images`
with `len(requests) == 1` works the same way as `annotate_images`. But maybe
I'm wrong.
Good guess! Indeed, looking at the source code for `annotate_image`, it is
essentially just a wrapper around `batch_annotate_images` like so `r =
self.batch_annotate_images([request], retry=retry, timeout=timeout)`.
I'll need to keep the min_batch_size and max_batch_size parameters for
testing purposes, in order to get a valid count of the API calls as otherwise
the number of calls is dependent on the BatchElements transform. But I'll make
sure to document these two parameters as such.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 393234)
Time Spent: 4h 20m (was: 4h 10m)
> [Python] PTransform that integrates Cloud Vision functionality
> --------------------------------------------------------------
>
> Key: BEAM-9247
> URL: https://issues.apache.org/jira/browse/BEAM-9247
> Project: Beam
> Issue Type: Sub-task
> Components: io-py-gcp
> Reporter: Kamil Wasilewski
> Assignee: Elias Djurfeldt
> Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> The goal is to create a PTransform that integrates Google Cloud Vision API
> functionality [1].
> [1] https://cloud.google.com/vision/docs/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
