[
https://issues.apache.org/jira/browse/BEAM-9384?focusedWorklogId=393634&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-393634
]
ASF GitHub Bot logged work on BEAM-9384:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/20 17:24
Start Date: 26/Feb/20 17:24
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #10974: [BEAM-9384]
Add SchemaRegistry.getSchemaCoder to get SchemaCoders for registered types
URL: https://github.com/apache/beam/pull/10974#discussion_r384645607
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaRegistry.java
##########
@@ -288,6 +281,38 @@ public void registerSchemaProvider(SchemaProvider
schemaProvider) {
return getProviderResult((SchemaProvider p) ->
p.fromRowFunction(typeDescriptor));
}
+ /**
+ * Retrieve a {@link SchemaCoder} for a given {@link Class} type. If no
schema exists, throws
+ * {@link * NoSuchSchemaException}.
+ */
+ public <T> SchemaCoder<T> getSchemaCoder(Class<T> clazz) throws
NoSuchSchemaException {
+ return getSchemaCoder(TypeDescriptor.of(clazz));
+ }
+
+ /**
+ * Retrieve a {@link SchemaCoder} for a given {@link TypeDescriptor} type.
If no schema exists,
+ * throws {@link * NoSuchSchemaException}.
+ */
+ public <T> SchemaCoder<T> getSchemaCoder(TypeDescriptor<T> typeDescriptor)
+ throws NoSuchSchemaException {
+ return SchemaCoder.of(
+ getSchema(typeDescriptor),
+ typeDescriptor,
+ getToRowFunction(typeDescriptor),
+ getFromRowFunction(typeDescriptor));
Review comment:
This looks fine, but can you explain the use case? The goal was for users to
never have to deal with SchemaCoder (the fact that schemas are implemented via
a special coder should be a Beam implementation details), but I'd understand if
we have cases where the coder is still needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 393634)
Time Spent: 40m (was: 0.5h)
> Add SchemaRegistry.getSchemaCoder to get SchemaCoders for registered types
> --------------------------------------------------------------------------
>
> Key: BEAM-9384
> URL: https://issues.apache.org/jira/browse/BEAM-9384
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> PTransforms that are parameterized by types may be able to infer a valid
> SchemaCoder for a given type from the SchemaRegistry (if a Schema for the
> given type is available). This method will provide a unified place to do that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
