[
https://issues.apache.org/jira/browse/BEAM-9056?focusedWorklogId=393773&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-393773
]
ASF GitHub Bot logged work on BEAM-9056:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/20 21:59
Start Date: 26/Feb/20 21:59
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #10621:
[BEAM-9056] Staging artifacts from environment
URL: https://github.com/apache/beam/pull/10621#discussion_r384729053
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents.java
##########
@@ -261,14 +263,20 @@ public String registerCoder(Coder<?> coder) throws
IOException {
* return the same unique ID.
*/
public String registerEnvironment(Environment env) {
+ String environmentId;
String existing = environmentIds.get(env);
if (existing != null) {
- return existing;
+ environmentId = existing;
+ } else {
+ String name = uniqify(env.getUrn(), environmentIds.values());
+ environmentIds.put(env, name);
+ componentsBuilder.putEnvironments(name, env);
+ environmentId = name;
}
- String name = uniqify(env.getUrn(), environmentIds.values());
- environmentIds.put(env, name);
- componentsBuilder.putEnvironments(name, env);
- return name;
+ if (defaultEnvironmentId == null) {
Review comment:
Probably it's better to explicitly declare the given environment as the
default (through an additional argument to registerEnvironment()) instead of
assuming first one that was passed to here to be the default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 393773)
Time Spent: 2h 50m (was: 2h 40m)
> Staging artifacts from environment
> ----------------------------------
>
> Key: BEAM-9056
> URL: https://issues.apache.org/jira/browse/BEAM-9056
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> staging artifacts from artifact information embedded in environment proto.
> detail:
> https://docs.google.com/document/d/1L7MJcfyy9mg2Ahfw5XPhUeBe-dyvAPMOYOiFA1-kAog
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
