[
https://issues.apache.org/jira/browse/BEAM-9288?focusedWorklogId=394532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394532
]
ASF GitHub Bot logged work on BEAM-9288:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/20 23:44
Start Date: 27/Feb/20 23:44
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #10940:
[BEAM-9288] Not bundle conscrypt in gRPC vendor
URL: https://github.com/apache/beam/pull/10940#discussion_r385434469
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/VendorJavaPlugin.groovy
##########
@@ -286,8 +288,23 @@ artifactId=${project.name}
pom.withXml {
def root = asNode()
def dependenciesNode = root.appendNode('dependencies')
+ def unshaded = { dependency ->
+ if (dependency instanceof ProjectDependency) {
+ def groupId =
dependency.getDependencyProject().mavenGroupId
+ def artifactId =
dependency.getDependencyProject().archivesBaseName
+ def version = dependency.version
+ return config.unshadedDependencies != null &&
config.unshadedDependencies.contains("$groupId:$artifactId:$version")
+ } else {
+ def groupId = dependency.group
+ def artifactId = dependency.name
+ def version = dependency.version
+ return config.unshadedDependencies != null &&
config.unshadedDependencies.contains("$groupId:$artifactId:$version")
Review comment:
This does not include the classifier. And since leaving out the classifier
is equal to `jar` (I think always?) it is not just a string comparison.
Does Gradle utilities have anything to parse the `unshadedDependencies` into
`ProjectDependency` objects and then use equality on that object?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 394532)
Time Spent: 2h (was: 1h 50m)
> Conscrypt shaded dependency
> ---------------------------
>
> Key: BEAM-9288
> URL: https://issues.apache.org/jira/browse/BEAM-9288
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Esun Kim
> Assignee: sunjincheng
> Priority: Critical
> Fix For: 2.20.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Conscrypt is not designed to be shaded properly mainly because of so files. I
> happened to see BEAM-9030 (*1) creating a new vendored gRPC shading Conscrypt
> (*2) in it. I think this could make a problem when new Conscrypt is brought
> by new gcsio depending on gRPC-alts (*4) in a dependency chain. (*5) In this
> case, it may have a conflict when finding proper so files for Conscrypt.
> *1: https://issues.apache.org/jira/browse/BEAM-9030
> *2:
> [https://github.com/apache/beam/blob/e24d1e51cbabe27cb3cc381fd95b334db639c45d/buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy#L78]
> *3: https://issues.apache.org/jira/browse/BEAM-6136
> *4: [https://mvnrepository.com/artifact/io.grpc/grpc-alts/1.27.0]
> *5: https://issues.apache.org/jira/browse/BEAM-8889
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
