[
https://issues.apache.org/jira/browse/BEAM-9288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047343#comment-17047343
]
Ismaël Mejía edited comment on BEAM-9288 at 2/28/20 9:09 AM:
-------------------------------------------------------------
Oh I see that's clearly a mistake I will unlink the issues because they are not
related. BEAM-9252 was all about users being unable to shade the Jar and this
is solved. This issue is different.
Conscrypt seems like a transitive dependency that gRPC uses, but that Beam's
use of gRPC may not use. If that's the case we can go with it even if it is
badly shaded, but well I understand if you guys prefer to do it properly, I
just wanted to avoid delaying the release if we can go with it as it is.
was (Author: iemejia):
Oh I see that's clearly a mistake I will unlink the issues because they are not
related. BEAM-9252 was all about users being unable to shade the Jar and this
is solved. This issue is different.
My comment about Beam's use of the dependency is related to the fact that it
looks like a transitive dependency that gRPC uses, but that our use of gRPC
might not use. If that's the case we can go with it even if it is badly shaded,
but well I understand if you guys prefer to do it properly, I just wanted to
avoid delaying the release if we can go with it as it is.
> Conscrypt shaded dependency
> ---------------------------
>
> Key: BEAM-9288
> URL: https://issues.apache.org/jira/browse/BEAM-9288
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Esun Kim
> Assignee: sunjincheng
> Priority: Critical
> Fix For: 2.20.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Conscrypt is not designed to be shaded properly mainly because of so files. I
> happened to see BEAM-9030 (*1) creating a new vendored gRPC shading Conscrypt
> (*2) in it. I think this could make a problem when new Conscrypt is brought
> by new gcsio depending on gRPC-alts (*4) in a dependency chain. (*5) In this
> case, it may have a conflict when finding proper so files for Conscrypt.
> *1: https://issues.apache.org/jira/browse/BEAM-9030
> *2:
> [https://github.com/apache/beam/blob/e24d1e51cbabe27cb3cc381fd95b334db639c45d/buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy#L78]
> *3: https://issues.apache.org/jira/browse/BEAM-6136
> *4: [https://mvnrepository.com/artifact/io.grpc/grpc-alts/1.27.0]
> *5: https://issues.apache.org/jira/browse/BEAM-8889
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
