[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=395358&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-395358
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Feb/20 01:03
Start Date: 29/Feb/20 01:03
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #10497: [BEAM-8335]
Add the ReverseTestStream
URL: https://github.com/apache/beam/pull/10497#discussion_r385984734
##########
File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
##########
@@ -421,8 +424,12 @@ def process_element(self, element):
main_output = list(self._outputs)[0]
bundle = self._evaluation_context.create_bundle(main_output)
for tv in event.timestamped_values:
- bundle.output(
- GlobalWindows.windowed_value(tv.value, timestamp=tv.timestamp))
+ # Unreify the value into the correct window.
+ try:
+ bundle.output(WindowedValue(**tv.value))
+ except TypeError:
+ bundle.output(
+ GlobalWindows.windowed_value(tv.value, timestamp=tv.timestamp))
Review comment:
Question:
What happens if tv.value is a dict from the upstream pcollection?
We are supposing that it's a dict containing the window, pane info, value,
and tstamp OR if we get a typeerror, then it's not a dict, it's only the
element itself - but what if the element itself is a dict?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 395358)
Time Spent: 78h (was: 77h 50m)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 78h
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
