[
https://issues.apache.org/jira/browse/BEAM-9274?focusedWorklogId=396438&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-396438
]
ASF GitHub Bot logged work on BEAM-9274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/20 22:21
Start Date: 02/Mar/20 22:21
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #10810: [BEAM-9274]
Support running yapf in a git pre-commit hook
URL: https://github.com/apache/beam/pull/10810#discussion_r386686435
##########
File path: .pre-commit-config.yaml
##########
@@ -0,0 +1,32 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+repos:
+ - repo: https://github.com/pre-commit/mirrors-yapf
+ # this rev is a release tag in the repo above and corresponds with a yapf
+ # version. make sure this matches the version of yapf in tox.ini.
+ rev: v0.29.0
Review comment:
done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 396438)
Time Spent: 2h (was: 1h 50m)
> Support running yapf in a git pre-commit hook
> ---------------------------------------------
>
> Key: BEAM-9274
> URL: https://issues.apache.org/jira/browse/BEAM-9274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> As a developer I want to be able to automatically run yapf before I make a
> commit so that I don't waste time with failures on jenkins.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
