[
https://issues.apache.org/jira/browse/BEAM-9360?focusedWorklogId=397828&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397828
]
ASF GitHub Bot logged work on BEAM-9360:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/20 19:53
Start Date: 04/Mar/20 19:53
Worklog Time Spent: 10m
Work Description: JozoVilcek commented on issue #10943: [BEAM-9360] Fix
equivalence check for FieldType
URL: https://github.com/apache/beam/pull/10943#issuecomment-594795878
The problem was not in the protobuf extensions. It just did stumble upon bug
in schema through regular use it. Test case makes sure that FieldTypes, part of
schema, are compared correctly in terms of equivalence. Does not matter which
schema provider actually did generate them.
I believe test is sufficient. If you do have specific suggestions to add for
improving quality and coverage, I am happy to work on them. Otherwise, imho it
is ready for merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 397828)
Time Spent: 50m (was: 40m)
> Schema FieldType should not consider metadata for equivalence
> -------------------------------------------------------------
>
> Key: BEAM-9360
> URL: https://issues.apache.org/jira/browse/BEAM-9360
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.19.0
> Reporter: Jozef Vilcek
> Assignee: Jozef Vilcek
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> FieldType `equivalent()` check should not require exact match in fields
> metadata.
> Discussion in dev mailing list:
> [https://lists.apache.org/[email protected]:lte=1M:Schema%20Convert%20transform%20fails%20on%20type%20metadata]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
