[ 
https://issues.apache.org/jira/browse/BEAM-9433?focusedWorklogId=398450&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398450
 ]

ASF GitHub Bot logged work on BEAM-9433:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Mar/20 15:53
            Start Date: 05/Mar/20 15:53
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on pull request #11048: 
[BEAM-9433] Create expansion service artifact for common Java IOs.
URL: https://github.com/apache/beam/pull/11048#discussion_r388067898
 
 

 ##########
 File path: sdks/python/apache_beam/io/external/kafka.py
 ##########
 @@ -57,6 +58,10 @@
     ])
 
 
+def default_io_expansion_service():
+  return BeamJarExpansionService('sdks:java:io:expansion-service:shadowJar')
 
 Review comment:
   Probably add a comment here or in  BeamJarExpansionService to clarify how 
this works. 
   IIUC,
   (1) For Beam version 2.x.y, we'll download the released kafka Jar for 
version 2.x.y
   (2) For Beam HEAD at version 2.(x+1).y.dev, we'll download the Beam Kafka 
Java jar for version 2.(x+1).y-SNAHSHOT
   (3) We'll always cache downloaded jars (in a sub-directory of the current 
directory ?). Please make sure that caching work for both released and 
non-released Beam.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 398450)
    Time Spent: 50m  (was: 40m)

> Create an expansion service artifact for common IOs
> ---------------------------------------------------
>
>                 Key: BEAM-9433
>                 URL: https://issues.apache.org/jira/browse/BEAM-9433
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-java-kafka, sdk-java-core, sdk-py-core
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> This will allow users to easily leverage Java IOs from Python/Go/... 
> pipelines. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to