[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=398584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398584
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/20 18:27
Start Date: 05/Mar/20 18:27
Worklog Time Spent: 10m
Work Description: KevinGG commented on pull request #11050: [BEAM-8335]
Implemented Capture Size limitation
URL: https://github.com/apache/beam/pull/11050#discussion_r388479176
##########
File path:
sdks/python/apache_beam/runners/interactive/background_caching_job.py
##########
@@ -202,10 +202,20 @@ def has_source_to_cache(user_pipeline):
if has_cache:
if not isinstance(ie.current_env().cache_manager(),
streaming_cache.StreamingCache):
- # TODO(BEAM-8335): convert the cache manager into a streaming cache
- # manager. Note this does not invalidate the current cache including the
- # source data capture.
- pass
+ # Wrap the cache manager into a streaming cache manager. Note this
+ # does not invalidate the current cache manager.
+ def is_cache_complete():
+ job = ie.current_env().get_background_caching_job(user_pipeline)
+ is_done = job and job.is_done()
+ cache_changed = is_source_to_cache_changed(
+ user_pipeline, update_cached_source_signature=False)
+ return is_done and not cache_changed
+
+ ie.current_env().set_cache_manager(
+ streaming_cache.StreamingCache(
+ ie.current_env().cache_manager()._cache_dir,
+ is_cache_complete=is_cache_complete,
Review comment:
`is_cache_complete` is a function required by StreamingCache, not the return
value of the function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 398584)
Time Spent: 95.5h (was: 95h 20m)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 95.5h
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
