[
https://issues.apache.org/jira/browse/BEAM-9305?focusedWorklogId=399007&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-399007
]
ASF GitHub Bot logged work on BEAM-9305:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/20 09:13
Start Date: 06/Mar/20 09:13
Worklog Time Spent: 10m
Work Description: kamilwu commented on pull request #11040: [BEAM-9305]
Allow value provider query strings in _CustomBigQuerySource
URL: https://github.com/apache/beam/pull/11040#discussion_r388788211
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py
##########
@@ -156,12 +157,19 @@ def test_native_source(self):
@attr('IT')
def test_iobase_source(self):
+ query = StaticValueProvider(str, self.query)
with beam.Pipeline(argv=self.args) as p:
result = (
p | 'read' >> beam.io._ReadFromBigQuery(
query=self.query, use_standard_sql=True, project=self.project))
assert_that(result, equal_to(self.TABLE_DATA))
+ with beam.Pipeline(argv=self.args) as p:
Review comment:
Do we need an integration test to cover your value provider's logic? Take a
look at `TestReadFromBigQuery` test case in `bigquery_test.py`. Those are unit
tests for `_ReadFromBigQuery` that actually run very fast, because pipeline is
not executed.
Adding new tests in `bigquery_read_it_test.py` causes huge overhead, since
they are all executed by three runners (Direct, Dataflow and Flink) on every
supported Python version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 399007)
Time Spent: 1h 40m (was: 1.5h)
> Support ValueProvider for BigQuerySource query string
> -----------------------------------------------------
>
> Key: BEAM-9305
> URL: https://issues.apache.org/jira/browse/BEAM-9305
> Project: Beam
> Issue Type: New Feature
> Components: io-py-gcp
> Reporter: Elias Djurfeldt
> Assignee: Elias Djurfeldt
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Users should be able to use ValueProviders for the query string in
> BigQuerySource.
> Ref:
> [https://stackoverflow.com/questions/60146887/expected-eta-to-avail-pipeline-i-o-and-runtime-parameters-in-apache-beam-gcp-dat/60170614?noredirect=1#comment106464448_60170614]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
