[
https://issues.apache.org/jira/browse/BEAM-8382?focusedWorklogId=400538&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400538
]
ASF GitHub Bot logged work on BEAM-8382:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/20 03:09
Start Date: 10/Mar/20 03:09
Worklog Time Spent: 10m
Work Description: jfarr commented on issue #9765: [BEAM-8382] Add rate
limit policy to KinesisIO.Read
URL: https://github.com/apache/beam/pull/9765#issuecomment-596878950
https://github.com/apache/beam/pull/11090
On Mon, Mar 9, 2020 at 3:34 PM Jonothan Farr <[email protected]>
wrote:
> Sure, I will take a look.
>
> On Mar 9, 2020, at 9:29 AM, Alexey Romanenko <[email protected]>
> wrote:
>
>
>
> Hmm, there is some flaky test in KinesisIO caused by
>
org.apache.beam.sdk.io.kinesis.ShardReadersPoolTest.shouldCallRateLimitPolicy
> introduced in this PR. Could you take a look please on this issue
> <https://issues.apache.org/jira/browse/BEAM-8382>?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/9765?email_source=notifications&email_token=AAL22D52IPZYGND33IRGISDRGUKM3A5CNFSM4I7T2Q72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOH6XHI#issuecomment-596634525>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAL22DZYJOTWI66J5UUW3D3RGUKM3ANCNFSM4I7T2Q7Q>
> .
>
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 400538)
Time Spent: 15h 50m (was: 15h 40m)
> Add polling interval to KinesisIO.Read
> --------------------------------------
>
> Key: BEAM-8382
> URL: https://issues.apache.org/jira/browse/BEAM-8382
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kinesis
> Affects Versions: 2.13.0, 2.14.0, 2.15.0
> Reporter: Jonothan Farr
> Assignee: Jonothan Farr
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
> With the current implementation we are observing Kinesis throttling due to
> ReadProvisionedThroughputExceeded on the order of hundreds of times per
> second, regardless of the actual Kinesis throughput. This is because the
> ShardReadersPool readLoop() method is polling getRecords() as fast as
> possible.
> From the KDS documentation:
> {quote}Each shard can support up to five read transactions per second.
> {quote}
> and
> {quote}For best results, sleep for at least 1 second (1,000 milliseconds)
> between calls to getRecords to avoid exceeding the limit on getRecords
> frequency.
> {quote}
> [https://docs.aws.amazon.com/streams/latest/dev/service-sizes-and-limits.html]
> [https://docs.aws.amazon.com/streams/latest/dev/developing-consumers-with-sdk.html]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
