[
https://issues.apache.org/jira/browse/BEAM-9474?focusedWorklogId=400654&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400654
]
ASF GitHub Bot logged work on BEAM-9474:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/20 10:57
Start Date: 10/Mar/20 10:57
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #11084: [BEAM-9474]
Improve robustness of BundleFactory and ProcessEnvironment
URL: https://github.com/apache/beam/pull/11084#discussion_r390235549
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/DefaultJobBundleFactory.java
##########
@@ -166,11 +168,20 @@ public static DefaultJobBundleFactory create(
CacheBuilder.newBuilder()
.removalListener(
(RemovalNotification<Environment, WrappedSdkHarnessClient>
notification) -> {
- int refCount = notification.getValue().unref();
- LOG.debug(
- "Removed environment {} with {} remaining bundle
references.",
- notification.getKey(),
- refCount);
+ WrappedSdkHarnessClient client = notification.getValue();
Review comment:
You are right that we can't close the environment during removal due to
pending references hold by still-processing bundles. Please take a look at the
follow-up. I'm now quarantining clients which still hold references, to remove
them during shutdown if they have not been dereferenced before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 400654)
Time Spent: 3h 10m (was: 3h)
> Environment cleanup is not robust enough and may leak resources
> ---------------------------------------------------------------
>
> Key: BEAM-9474
> URL: https://issues.apache.org/jira/browse/BEAM-9474
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The cleanup code in {{DefaultJobBundleFactory}} and its {{RemoteEnvironment}}
> s may leak resources. This is especially a concern when the execution engines
> reuses the same JVM or underlying machines for multiple runs of a pipeline.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
