[
https://issues.apache.org/jira/browse/BEAM-9295?focusedWorklogId=400665&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400665
]
ASF GitHub Bot logged work on BEAM-9295:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/20 11:09
Start Date: 10/Mar/20 11:09
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #10945: [BEAM-9295] Add
Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10
URL: https://github.com/apache/beam/pull/10945#discussion_r390240614
##########
File path:
runners/flink/src/test/java/org/apache/beam/runners/flink/FlinkExecutionEnvironmentsTest.java
##########
@@ -438,8 +424,34 @@ public void shouldSetSavepointRestoreForRemoteStreaming()
{
options, Collections.emptyList());
// subject to change with https://issues.apache.org/jira/browse/FLINK-11048
assertThat(sev, instanceOf(RemoteStreamEnvironment.class));
- assertThat(
- Whitebox.getInternalState(sev, "restoreSettings"),
- is(SavepointRestoreSettings.forPath(path)));
+ assertThat(getSavepointPath(sev), is(path));
+ }
+
+ private void checkHostAndPort(Object env, String expectedHost, int
expectedPort) {
+ try {
+ assertThat(Whitebox.getInternalState(env, "host"), is(expectedHost));
+ assertThat(Whitebox.getInternalState(env, "port"), is(expectedPort));
+ } catch (Throwable t) {
Review comment:
We shouldn't be catching throwable here.
```suggestion
} catch (FieldNotFoundException e) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 400665)
Time Spent: 4.5h (was: 4h 20m)
> Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10
> ---------------------------------------------------------------------------
>
> Key: BEAM-9295
> URL: https://issues.apache.org/jira/browse/BEAM-9295
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Apache Flink 1.10 has completed the final release vote, see [1]. So, I would
> like to add Flink 1.10 build target and make Flink Runner compatible with
> Flink 1.10.
> And I appreciate it if you can leave your suggestions or comments!
> [1]
> https://lists.apache.org/thread.html/r97672d4d1e47372cebf23e6643a6cc30a06bfbdf3f277b0be3695b15%40%3Cdev.flink.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
